MSVC 9.0 error due to unimplemented "copy constructors" in weightinternal.h

[Peter Kelm]

MSVC 9.0 cannot compile trunk due to unimplemented "copy constructors" in weightinternal.h. They lead to the following link error:

NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio 9.0\VC\bin\link.exe"' : return code '0x460'
libnet.lib(serialise.obj) : error LNK2019: unresolved external symbol "public: __thiscall Xapian::Weight::Internal::Internal(class Xapian::Weight::Internal const &)" (??0Internal@Weight@Xapian@@QAE@ABV012@@Z) referenced in function "class Xapian::Weight::Internal __cdecl unserialise_stats(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?unserialise_stats@@YA?AVInternal@Weight@Xapian@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)

Proposed fix:

Either commenting the following in the header as below:

    /** Create a Weight::Internal object with global statistics.
     *
     *  All term-specific statistics will be set to 0.
     *
     *  @param stats  Object containing the statistics to use.
     */
//  Internal(const Internal & stats);

    /** Create a Weight::Internal object with global and term statistics.
     *
     *  @param stats  Object containing the statistics to use.
     *  @param term   The term to read the term-specific statistics for.
     */
//  Internal(const Internal & stats, const std::string & term);

or actually implementing them.

[Olly Betts]

Thanks, fixed in trunk r12832.