Php constants defined in RINIT and not in MINIT

[Ludovic Levesque]

When loading a page php logs error like this (several lines): PHP Notice: Constant QueryParser_STEM_ALL already defined in Unknown on line 0

It's because all constant are defined in PHP_RINIT_FUNCTION(xapian) in xapian_wrap.cc. They must be defined in SWIG_php_minit (equivalent of PHP_MINIT_FUNCTION(xapian).

[Olly Betts]

It looks like the problem is with the code SWIG generates. It's easy enough to move the generated code from RINIT to MINIT, and I have commit access to the SWIG repository so I can make the change, but I can't seem to find any PHP or Zend documentation which documents where constant initialisation should go.

I think you're probably right, but I'm cautious since SWIG is used by many projects and the code looks like it's been this way for some time.

Are you able to supply a URL for some suitable documentation?

[Olly Betts]

OK, I've found this, which documents that CONST_PERSISTENT means the constant "won't be "forgotten" when the current process carrying this constant shuts down.":

​http://www.zend.com/apidoc/zend.variables.constant.php

And this which says to create constants in MINIT:

​http://www.zend.com/apidoc/zend.variables.resource.php

So I'll apply a suitable patch to SWIG.

[Olly Betts]

Fixed in SWIG CVS.