#76 closed defect (released)
php smoketest fails with php5
Reported by: | Marien Zwart | Owned by: | Olly Betts |
---|---|---|---|
Priority: | high | Milestone: | |
Component: | Xapian-bindings | Version: | 0.9.6 |
Severity: | minor | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Operating System: | Linux |
Description
When running make check with php5 I get:
Fatal error: Uncaught exception 'Exception' with message 'DocNotFoundError: Docid 2 not found' in /var/tmp/portage/xapian-bindings-0.9.6/work/xapian-bindings-0.9.6/php/smoketest.php:108 Stack trace: #0 /var/tmp/portage/xapian-bindings-0.9.6/work/xapian-bindings-0.9.6/php/smoketest.php(108): database_get_document(Resource id #6, 2) #1 {main}
thrown in
/var/tmp/portage/xapian-bindings-0.9.6/work/xapian-bindings-0.9.6/php/smoketest.php on line 108 FAIL: smoketest.php
With php4 everything passes. It looks like this is just a bug in the smoketest.php: there should probably be a separate php5 smoketest since those bindings raise exceptions while the php4 ones do not.
Attachments (2)
Change History (7)
comment:1 by , 19 years ago
Status: | new → assigned |
---|
by , 19 years ago
Attachment: | xapian-php5-smoketest.patch added |
---|
Patch which should fix smoketest on PHP5
comment:2 by , 19 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
OK, I can build now and the patch fixes it for me, so I've applied it.
Thanks for reporting the problem!
by , 19 years ago
Attachment: | xapian-bindings-0.9.6-php-tests-2.patch added |
---|
Extra php 5 smoketest fixes.
comment:3 by , 19 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Sorry for the delay. Had to apply the oneliner I just attached on top of the other patch for the tests to pass with php-5.1.4. Without this I get a "Parse error".
comment:4 by , 19 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
D'oh! Thanks for spotting this.
comment:5 by , 18 years ago
Operating System: | → Linux |
---|---|
Resolution: | fixed → released |
Yeah, I fixed a bug which was stopping exceptions from being used in PHP5 like they were meant to be, but failed to update the smoketest.