configure does not fail if sphinx is missing in Python 2

[Patricio Paez]

./configure --with-python does not stop after checking for sphinx and finding that sphinx is not found. The execution of configure ends in this message:

*** Not found the required tools for building bindings for any
*** supported language!
***
*** You may need to install -dev or -devel packages for the languages
*** you want to build bindings for.
***
*** For details of how to point configure at tools not on PATH, see:
***     ./configure --help

The correct behavior should be to issue this message and stop, similar to Python 3:

configure: error: Couldn't import sphinx module and call sphinx.main() for Python2 - try package python-sphinx

This issue was introduced inadvertently in commit 723eae9daf6f89d865f667c10921f57201f66941 dated December 6th, 2016.

The following patch was tested in Debian stretch and fixes the issue:

pp@g6:~/Downloads/src/xapian$ diff -Naur xapian-bindings/configure.ac{-ori,}
--- xapian-bindings/configure.ac-ori	2017-04-01 19:32:40.069217157 -0500
+++ xapian-bindings/configure.ac	2017-04-01 20:29:58.515855408 -0500
@@ -356,7 +356,7 @@
       AC_MSG_RESULT([yes])
     else
       AC_MSG_RESULT([no])
-      if test yes = "$with_python2" ; then
+      if test yes = "$with_python" ; then
 	AC_MSG_ERROR([Couldn't import sphinx module and call sphinx.main() for Python2 - try package python-sphinx])
       fi
       PYTHON2=

Regards,

Patricio

[Olly Betts]

Thanks for spotting and reporting. Marking for 1.4.4.

[Olly Betts]

Fixed in git master by cb4e972e37e5015d35cb53d16495aa1cdc8fc6bd, backported for 1.4.4 as 4dc9de02e5da18c62beda92261152fe79ad6f80e. Doesn't affect 1.2.x.

Thanks again for the patch.