Opened 8 years ago

Closed 8 years ago

#745 closed defect (fixed)

gde_base_type for getdirentries() in OS X is long

Reported by: German M. Bravo Owned by: Olly Betts
Priority: normal Milestone: 1.4.2
Component: Other Version:
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Operating System: All

Description

The type of gde_base_type, passed to getdirentries(), in in OS X (at least in macOS and El Capitan) is of type long. The man page says: int getdirentries(int fd, char *buf, int nbytes, long *basep);

  • xapian-core/common/closefrom.cc

    a b Xapian::Internal::closefrom(int fd)  
    9393    typedef off_t gde_base_type;
    9494#elif defined __APPLE__ // Mac OS X
    9595    const char * path = "/dev/fd";
    96     typedef int gde_base_type;
     96    typedef long gde_base_type;
    9797#endif
    9898    int dir = open(path, O_RDONLY|O_DIRECTORY);
    9999    if (dir >= 0) {

Change History (1)

comment:1 by Olly Betts, 8 years ago

Milestone: → 1.4.2
Resolution: → fixed
Status: new → closed

Thanks, fixed in master by fb833b5e23fe278f11d240be4f6d18b59b88b97a and RELEASE/1.4 by 8bf7ba090c9e7d00fcf7384dbaff89aef58b80af.

Note: See TracTickets for help on using tickets.