#733 closed enhancement (fixed)
Change the way Features request statistics
| Reported by: | Ayush Tomar | Owned by: | Ayush Pandey |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.5.0 |
| Component: | Letor (Learning To Rank) | Version: | 1.4.0 |
| Severity: | normal | Keywords: | Letor features |
| Cc: | Blocked By: | ||
| Blocking: | Operating System: | All |
Description
At present, Feature::Internal class does the work of calculating statistics like normalised lengths, query term frequencies, etc,. Feature subclasses then request these statistics from get_value() method. Due to presence of Internal member in Feature class, subclassing Feature is not easy as well.
The following changes need to be made:
Feature::Internalshould be eliminated and its functionality (i.e. calculating and supplying statistics toFeaturesubclasses) should be made part ofFeatureListclass (probably asFeatureList::Internalclass).
- It's possible that we could also do the thing
Weightdoes, and have eachFeaturesubclass report which statistics it needs, soFeatureListcan calculate them each once in advance before callingget_value()on all itsFeatureobjects.
Change History (4)
comment:1 by , 9 years ago
comment:2 by , 9 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:4 by , 8 years ago
| Milestone: | → 1.5.0 |
|---|
Setting milestone to the release this should debut in.
Note:
See TracTickets
for help on using tickets.

Hi ............ wanted to Know if the said changes were made or can I claim this ticket and start working on it