Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#733 closed enhancement (fixed)

Change the way Features request statistics

Reported by: Ayush Tomar Owned by: Ayush Pandey
Priority: normal Milestone: 1.5.0
Component: Letor (Learning To Rank) Version: 1.4.0
Severity: normal Keywords: Letor features
Cc: Blocked By:
Blocking: Operating System: All

Description

At present, Feature::Internal class does the work of calculating statistics like normalised lengths, query term frequencies, etc,. Feature subclasses then request these statistics from get_value() method. Due to presence of Internal member in Feature class, subclassing Feature is not easy as well.

The following changes need to be made:

  1. Feature::Internal should be eliminated and its functionality (i.e. calculating and supplying statistics to Feature subclasses) should be made part of FeatureList class (probably as FeatureList::Internal class).
  1. It's possible that we could also do the thing Weight does, and have each Feature subclass report which statistics it needs, so FeatureList can calculate them each once in advance before calling get_value() on all its Feature objects.

Change History (4)

comment:1 by Ayush Pandey, 3 years ago

Hi ............ wanted to Know if the said changes were made or can I claim this ticket and start working on it

comment:2 by Ayush Pandey, 3 years ago

Owner: changed from Ayush Tomar to Ayush Pandey
Status: newassigned

comment:3 by Ayush Pandey, 3 years ago

Resolution: fixed
Status: assignedclosed

comment:4 by Olly Betts, 3 years ago

Milestone: 1.5.0

Setting milestone to the release this should debut in.

Note: See TracTickets for help on using tickets.