Opened 10 years ago

Closed 10 years ago

#676 closed defect (fixed)

Enable caching in xapian-config by fixing typo

Reported by: Ryan Carsten Schmidt Owned by: Olly Betts
Priority: normal Milestone: 1.2.21
Component: Build system Version: 1.2.20
Severity: minor Keywords:
Cc: Blocked By:
Blocking: Operating System: All

Description

Hello, I believe there is a typo in xapian-config such that the intended caching behavior of the is_uninstalled function is never actually used, and the value is recomputed each time the function is called. I believe the attached patch fixes this.

Attachments (1)

xapian-config.in.diff (378 bytes ) - added by Ryan Carsten Schmidt 10 years ago.

Download all attachments as: .zip

Change History (3)

by Ryan Carsten Schmidt, 10 years ago

Attachment: xapian-config.in.diff added

comment:1 by Olly Betts, 10 years ago

Component: OtherBuild system
Milestone: 1.2.21
Status: newassigned

Thanks, applied to git master in [716a2f331b9e34351b976cc680892d76c76e07c1/git].

Marking for backporting as it's a safe change, though I doubt the caching saves much time as it only avoids a test -f. But if we're caching an answer, we ought to use it!

comment:2 by Olly Betts, 10 years ago

Resolution: fixed
Status: assignedclosed

Backported for 1.2.21 in [6fa637d8b3200398944b075f9a00d8a1de677431].

Note: See TracTickets for help on using tickets.