Opened 10 years ago
Closed 10 years ago
#649 closed defect (fixed)
Compaction should open inputs at consistent revisions
| Reported by: | Olly Betts | Owned by: | Olly Betts |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.2.21 |
| Component: | Backend-Chert | Version: | SVN trunk |
| Severity: | normal | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Operating System: | All |
Description
Currently for chert and (in 1.2.x) flint and brass it opens at the latest revision each table has, which may not be the same revision if a change was partly committed but failed.
The new brass on trunk doesn't have this issue, as it uses the version file to open inputs for compaction.
I think in practice this case is rare, but it could result in a bad output from the compaction (inconsistencies between tables) so we should address it.
Change History (3)
comment:1 by , 10 years ago
| Status: | new → assigned |
|---|
comment:2 by , 10 years ago
| Milestone: | 1.3.3 → 1.2.21 |
|---|
comment:3 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Backported for 1.2.21 in [a0e8d4397c58af490f6c392dbc2b132a21775c73] and similarly fixed for brass and flint for 1.2.21 in [0f636389f21491447c20d74626fb5cc7b17c82b0].
Note:
See TracTickets
for help on using tickets.
Fixed in master by [ec3c64e] before 1.3.3.
It would be good to backport this to 1.2.x.