Opened 14 years ago

Closed 14 years ago

#509 closed defect (fixed)

syntax error in (cygwin python detection)

Reported by: jilles Owned by: Olly Betts
Priority: normal Milestone: 1.0.23
Component: Xapian-bindings Version: 1.0.18
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Operating System: All


The cygwin python detection added in r11804 contains a syntax error: the closing parenthesis should be inside the single-quotes, not outside. This means it can never have fulfilled the intended purpose.

(However, the build may have worked with ash variants as sh, because most of these have a bug that causes the extraneous parenthesis to be silently ignored. Python will then report a syntax error but this is not checked and PYTHON_LIBS ends up empty as if r11804 weren't there.)

I plan to fix the ash bug (in FreeBSD sh in particular), which causes the shell to abort when it encounters the error, even if the cygwin case is not executed. This is also how I found this bug.

After fixing the syntax error, PYTHON_LIBS appears to be set to sensible values for python 2.6 and 3.1. I do not have Windows so I cannot check if the cygwin build now works.

Attachments (1)

xapian-bindings-configure-syntaxfix.patch (702 bytes ) - added by jilles 14 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 by Olly Betts, 14 years ago

Milestone: 1.0.23
Status: newassigned

Hmm, looks like I messed up tweaking a working cygwin patch for Python 3 compatibility. Thanks for catching this. Fixed in trunk r15079. Needs backporting for 1.0.x.

FWIW, bash doesn't seem to mind the excess closing parenthesis either. Trying variations, it looks like it doesn't notice such errors inside backticks unless it is actually executing that codepath.

comment:2 by Olly Betts, 14 years ago

Resolution: fixed
Status: assignedclosed

And backported in r15080.

Note: See TracTickets for help on using tickets.