Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#438 closed enhancement (fixed)

Updated win32 build files, adding new Brass backend files

Reported by: Charlie Hull Owned by: Charlie Hull
Priority: normal Milestone: 1.1.4
Component: MSVC makefiles Version: SVN trunk
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Operating System: Microsoft Windows

Description

Enclosed is a patch to the Win32 build files that adds the Brass backend

Attachments (1)

patch39.patch (13.6 KB ) - added by Charlie Hull 12 years ago.
Patch

Download all attachments as: .zip

Change History (4)

by Charlie Hull, 12 years ago

Attachment: patch39.patch added

Patch

comment:1 by Charlie Hull, 12 years ago

Milestone: 1.1.4

comment:2 by Richard Boulton, 12 years ago

Resolution: fixed
Status: newclosed

Patch applied.

Please can you make sure that the ChangeLog entries correspond to all the changes made in your patches in future. I've updated the entry this time, but it only contained a reference to some of the files which had changed, and the comment "add Brass backend".

Detailed ChangeLog entries are important both to make it easier to find the source of problems in future. The process of writing them is also a good way to review the changes made in a patch, to ensure nothing has been inadvertently included which wasn't meant to be. Olly and I use a "svn-ci" script (available in xapian-maintainer-tools) which populates the ChangeLog file with a new entry listing all the files which have changed, and follows that with the diffs contained in the file. You might find it helpful to use this - I'm sure it could be made to work on windows without too much difficulty.

comment:3 by Charlie Hull, 12 years ago

Understood: as I didn't know that script existed I've been forced to update the ChangeLog by hand up to know, which is prone to error.

Note: See TracTickets for help on using tickets.