valuestreams not used by OP_VALUE_RANGE

[Richard Boulton]

The valuestream documents are not currently being used by OP_VALUE_RANGE (and also OP_VALUE_GE, etc) as far as I can tell. My main evidence for this is some profiling traces of a pure VALUE_RANGE search which doesn't call any ValueStreamDocument methods, but I also can't see any code which would allow a ValueStreamDocument to be used.

I'd expected ValueStreamDocument to be used for these, since it should reduce the amount of seeking around they need to do, and speed them up considerably. I think the ValueStreamDocument would need to become a member of MultiMatch, be created in the constructor, and passed to LocalSubMatch, and on to the query optimiser, to allow it to be used.

[Olly Betts]

ValueStreamDocument is only required because we need to be able to pass a Document object to user subclassable functors. OP_VALUE_RANGE only needs to read values from a single document slot, so should just use a valuestream iterator directly.

If we're worried about sharing a valuestream between filtering and sorting, etc then we should push the sharing mechanism into a separate place which just returns a shared valuestream iterator which we can use here, rather than forcing access through a Document proxy (which adds needless overhead) to achieve this.

Marking as an enhancement, since this isn't buggy, just slower than it could be.

[Olly Betts]

Marking for 1.2.1 - it shouldn't be hard to hook this up in a simple way at least.

[Olly Betts]

Fixed in trunk r14496. Valuestreams weren't in 1.0.x, so nothing to backport.