Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#420 closed defect (fixed)

Patch for a few Perl issues

Reported by: Henry Owned by: Olly Betts
Priority: normal Milestone: 1.0.18
Component: Search::Xapian Version: SVN trunk
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Operating System: All

Description

Please find attached a patch (against current svn) for consideration. It covers a few missing elements on the Perl side of things:

add_spelling() and test/s. remove_spelling() and test/s. get_corrected_query_string() and test/s. get_spelling_suggestion() and test/s.

man pages for the above and for WritableDatabase::close() are also patched.

Please let me know of any errors (especially in the test suites). I've successfully patched, compiled, and subsequently indexed using the changes.

Attachments (1)

xapian-perl.patch (7.4 KB ) - added by Henry 14 years ago.

Download all attachments as: .zip

Change History (5)

by Henry, 14 years ago

Attachment: xapian-perl.patch added

comment:1 by Olly Betts, 14 years ago

Component: Xapian-bindingsSearch::Xapian
Milestone: 1.0.18
Status: newassigned

The documentation for WritableDatabase::close should really be for Database::close, but this method doesn't seem to be wrapped for Perl anyway currently, so I've not applied that bit...

The rest I've committed as r13787.

Marking for backporting.

comment:2 by Olly Betts, 14 years ago

Resolution: fixed
Status: assignedclosed

Backported for 1.0.18 as r13789.

comment:3 by Henry, 14 years ago

My surname for the Changes file: Combrinck 'Henry' on it's own seems so mysterious.

comment:4 by Olly Betts, 14 years ago

OK, filled in - I couldn't remember what it was, or trivially find it.

Note: See TracTickets for help on using tickets.