Opened 15 years ago

Closed 15 years ago

#408 closed defect (fixed)

Fix off-by-one use of invalid fd in FlintLock::lock

Reported by: Carl Worth Owned by: Olly Betts
Priority: normal Milestone: 1.0.17
Component: Backend-Flint Version:
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Operating System: All

Description

This is likely totally harmless, but it was at least making the following warning be emitted by valgrind:

==13151== Warning: invalid file descriptor 1014 in syscall close()

I'll attach a patch that makes that warning go away.

-Carl

Attachments (1)

fix-off-by-one-maxfd.patch (644 bytes ) - added by Carl Worth 15 years ago.
Simple patch to fix the bug

Download all attachments as: .zip

Change History (3)

by Carl Worth, 15 years ago

Attachment: fix-off-by-one-maxfd.patch added

Simple patch to fix the bug

comment:1 by Olly Betts, 15 years ago

Component: OtherBackend-Flint
Milestone: 1.0.17
Status: newassigned

Applied to trunk (and also fixed for chert) in r13548.

Marking to backport for 1.0.17.

comment:2 by Olly Betts, 15 years ago

Resolution: fixed
Status: assignedclosed

Backported for 1.0.17 in r13585.

Note: See TracTickets for help on using tickets.