Opened 16 years ago

Closed 15 years ago

Last modified 15 years ago

#367 closed defect (fixed)

update msvc makefiles for generate-python-exceptions.in -> generate-python-exceptions

Reported by: Peter Kelm Owned by: Charlie Hull
Priority: normal Milestone: 1.1.4
Component: MSVC makefiles Version: SVN trunk
Severity: normal Keywords:
Cc: Charlie Hull Blocked By:
Blocking: Operating System: Microsoft Windows

Description

The trunk snapshots do not include all files necessary to build the project. The following are missing:

- "xapian-core/common/win32_uuid.cc" and "xapian-core/common/win32_uuid.h" in "xapian-core-*.tar.gz" 
- "xapian-bindings/python/generate-python-exceptions.in" in "xapian-bindings-*.tar.gz"

Change History (6)

comment:1 by Peter Kelm, 16 years ago

Summary: missing files in snapshot filesmissing files in snapshot archives

comment:2 by Olly Betts, 16 years ago

Cc: Charlie Hull added
Component: Build systemMSVC makefiles
Owner: changed from Olly Betts to Charlie Hull
Summary: missing files in snapshot archivesupdate msvc makefiles for generate-python-exceptions.in -> generate-python-exceptions

Fixed in trunk r12669 for xapian-core.

There no longer is a generate-python-exceptions.in in trunk - the only substitution being done was for the Python interpreter in the #! line, which we don't need to do and just slows up configure for no good reason. So just drop the ".in", and run it explicitly under python if it isn't already (I'd guess it already is, as #! isn't supported by MS AFAIK).

Re-titling and cc:ing Charlie.

comment:3 by Olly Betts, 16 years ago

Milestone: 1.1.1

comment:4 by Olly Betts, 16 years ago

Milestone: 1.1.1

I'm not going to hold 1.1.1 for this. People should be able to build from the release tarballs without needing this script, so it's only really relevant for SVN builds. Hence just unsetting the milestone.

comment:5 by Olly Betts, 15 years ago

Milestone: 1.1.4
Resolution: fixed
Status: newclosed

Well, no response from Charlie for 9 months, so I've committed the obvious changes in r13989, but of course I can't actually test them. Marking as fixed for now - please reopen if my attempted fix didn't work.

comment:6 by Charlie Hull, 15 years ago

Verified fixed in trunk.

Note: See TracTickets for help on using tickets.