nearsubqueries1 fails under valgrind

[Richard Boulton]

Running apitest under valgrind fails on my (linux, i686, ubuntu hardy) box with the attached errors.

According to Charlie, this test crashes on windows in the 1.0 branch - I'd guess that it's probably the same problem.

[Richard Boulton]

Output of ./runtest ./apitest nearsubqueries1 -v

[Olly Betts]

Yeah, this was uncovered when the valgrind logging problem was fixed and we suddenly saw all our valgrind errors - you even commented on it on #xapian-devel:

@1236013181 <richardb> ojwb: only nearsubqueries1 is failing for me (under valgrind) now. @1236013196 <richardb> Not sure I'm brave enough to try tackling it, though.

Given that the code there is really hard to follow, and hasn't changed for ages, I felt it was probably safer not to rush a fix for 1.0.11 - after all nobody has hit this in the wild.

[Olly Betts]

Ticket #201 is related. And I was wrong - this changed (albeit only assert -> exception) in 1.0.10.

I have a fix (which also fixes #201) but it fails to suck up sub-OR queries into a parent OR, etc so it really needs further work.

[Richard Boulton]

Would be worth knowing if your fix fixes the crash which Charlie observes on windows in the 1.0 branch - can you attach it as a patch here?

[Olly Betts]

Fixed in trunk r12228.

I'm virtually certain that this is the cause of Charlie's crash. The old code was rather ... odd. Be nice to have confirmation though.

Setting milestone:1.0.12

[Olly Betts]

Fixed for 1.0.12 in branches/1.0 r12258.