Opened 15 years ago
Closed 15 years ago
#339 closed defect (duplicate)
Change "name" method of Weight subclasses to return full name
| Reported by: | Richard Boulton | Owned by: | Olly Betts |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.1.0 |
| Component: | Other | Version: | SVN trunk |
| Severity: | normal | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Operating System: | All |
Description
The PostingSource::name() method currently returns the full name of the postingsource subclass (eg, Xapian::FooPostingSource). The Weight::name() method just returns a short name (eg, "Foo"). These methods should be consistent, and I think the full name approach is the best way to go.
This was already discussed in ticket #295, but I thought it useful to make a ticket so it didn't get forgotten.
Changing this will break the remote protocol, and possibly API depending how you define that, so marking for 1.1.0. On the other hand, it's very unlikely to break user implemented weight classes.
It's easy to fix, anyway - there's a patch attached to ticket #295, too: http://trac.xapian.org/attachment/ticket/295/weightnames.patch
No need for a reminder - I've already made this change in the patch I'm working on for #213.