Opened 12 years ago

Closed 3 years ago

#238 closed defect (fixed)

Improve test coverage of Database::check()

Reported by: richard Owned by: olly
Priority: normal Milestone: 1.4.4
Component: Test Suite Version: git master
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Operating System: All

Description (last modified by olly)

The Database::check() API (which xapian-check uses) is currently called from only one test case.


Original description:

The xapian-compact and xapian-check utilities have no test cases.

If bug #175 were fixed (so that the xapian-compact functionality was available in the C++ API) it would be possible to implement such tests as part of apitest.

It might also be generally useful to have a C++ API for xapian-check.

Therefore, I'm marking this bug as being blocked by #175, since if we're going to fix #175 that would be the easiest way to implement tests.

Change History (12)

comment:1 Changed 12 years ago by richard

  • Blocked By 175 added

comment:2 Changed 12 years ago by olly

  • Operating System set to All
  • Status changed from new to assigned

comment:4 Changed 11 years ago by olly

  • Description modified (diff)
  • Owner changed from newbugs to olly
  • Status changed from assigned to new

comment:5 Changed 10 years ago by olly

There are now some tests of xapian-compact in tests/api_compact.cc.

comment:6 Changed 9 years ago by olly

  • Description modified (diff)
  • Milestone set to 1.2.x

This could be done in 1.2.x, so setting milestone.

comment:7 Changed 9 years ago by olly

  • Blocked By 175 removed

(In #175) Working on this currently.

The main missing pieces are what to do about progress output, and merging user metadata.

Removing block on #238, as we already have xapian-compact tests.

comment:7 Changed 9 years ago by olly

  • Description modified (diff)
  • Summary changed from No tests of xapian-compact or xapian-check to No tests of xapian-check

We now have quite a few tests of xapian-compact, so make this ticket about xapian-check's lack of testsuite coverage.

comment:8 Changed 8 years ago by olly

  • Description modified (diff)
  • Milestone changed from 1.2.x to 1.3.x
  • Summary changed from No tests of xapian-check to No tests of Database::check()

I've added an API for checking databases in r16316. There are currently no tests of this API, but it will at least now be a bit easier to write such tests.

Updated the summary and description to reflect this change.

comment:9 Changed 6 years ago by olly

  • Description modified (diff)
  • Summary changed from No tests of Database::check() to Improve test coverage of Database::check()

r17814 alters cursordelbug1 to call Xapian::Database::check(), so we now have at least some test coverage.

comment:10 Changed 4 years ago by olly

  • Milestone changed from 1.3.x to 1.4.x

While more test coverage here would be good, this isn't a blocker for 1.4.0.

comment:11 Changed 3 years ago by olly

  • Milestone changed from 1.4.x to 1.4.4
  • Status changed from new to assigned
  • Version changed from SVN trunk to git master

Addressed by d6617dc7e6ba79aa8876dcc87b98576c3f52edb9 and 742b83a64ed5263fabfe29a502320bbb81e1f6be in git master. Would be nice to backport for 1.4.4.

comment:12 Changed 3 years ago by olly

  • Resolution set to fixed
  • Status changed from assigned to closed

Backported to RELEASE/1.4 along with some additional fixes in a7fec21862a1535dd7b6b0d1def1a03c28971661 and commits around there.

Note: See TracTickets for help on using tickets.