Opened 17 years ago
Closed 8 years ago
#238 closed defect (fixed)
Improve test coverage of Database::check()
| Reported by: | Richard Boulton | Owned by: | Olly Betts |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.4.4 |
| Component: | Test Suite | Version: | git master |
| Severity: | normal | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Operating System: | All |
Description (last modified by )
The Database::check() API (which xapian-check uses) is currently called from only one test case.
Original description:
The xapian-compact and xapian-check utilities have no test cases.
If bug #175 were fixed (so that the xapian-compact functionality was available in the C++ API) it would be possible to implement such tests as part of apitest.
It might also be generally useful to have a C++ API for xapian-check.
Therefore, I'm marking this bug as being blocked by #175, since if we're going to fix #175 that would be the easiest way to implement tests.
Change History (12)
comment:1 by , 17 years ago
| Blocked By: | 175 added |
|---|
comment:2 by , 17 years ago
| Operating System: | → All |
|---|---|
| Status: | new → assigned |
comment:4 by , 17 years ago
| Description: | modified (diff) |
|---|---|
| Owner: | changed from to |
| Status: | assigned → new |
comment:5 by , 15 years ago
comment:6 by , 14 years ago
| Description: | modified (diff) |
|---|---|
| Milestone: | → 1.2.x |
This could be done in 1.2.x, so setting milestone.
comment:7 by , 14 years ago
| Blocked By: | 175 removed |
|---|
comment:7 by , 14 years ago
| Description: | modified (diff) |
|---|---|
| Summary: | No tests of xapian-compact or xapian-check → No tests of xapian-check |
We now have quite a few tests of xapian-compact, so make this ticket about xapian-check's lack of testsuite coverage.
comment:8 by , 13 years ago
| Description: | modified (diff) |
|---|---|
| Milestone: | 1.2.x → 1.3.x |
| Summary: | No tests of xapian-check → No tests of Database::check() |
I've added an API for checking databases in r16316. There are currently no tests of this API, but it will at least now be a bit easier to write such tests.
Updated the summary and description to reflect this change.
comment:9 by , 11 years ago
| Description: | modified (diff) |
|---|---|
| Summary: | No tests of Database::check() → Improve test coverage of Database::check() |
r17814 alters cursordelbug1 to call Xapian::Database::check(), so we now have at least some test coverage.
comment:10 by , 9 years ago
| Milestone: | 1.3.x → 1.4.x |
|---|
While more test coverage here would be good, this isn't a blocker for 1.4.0.
comment:11 by , 8 years ago
| Milestone: | 1.4.x → 1.4.4 |
|---|---|
| Status: | new → assigned |
| Version: | SVN trunk → git master |
Addressed by d6617dc7e6ba79aa8876dcc87b98576c3f52edb9 and 742b83a64ed5263fabfe29a502320bbb81e1f6be in git master. Would be nice to backport for 1.4.4.
comment:12 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Backported to RELEASE/1.4 along with some additional fixes in a7fec21862a1535dd7b6b0d1def1a03c28971661 and commits around there.
There are now some tests of xapian-compact in tests/api_compact.cc.