Distcheck is broken due to missing rule for documentation files

[Richard Boulton]

If I run "make distcheck", the "distdir" step in the generated distribution fails for me:

make[1]: Entering directory `/home/richard/private/Working/xapian/working/build/xapian-core/docs' make[1]: * No rule to make target apidoc/html/*.gif', needed by distdir'. Stop.

This appears to have been a problem since revision 9747: see the following link for the details of what changed there:

​http://svn.xapian.org/trunk/xapian-core/docs/Makefile.am?r1=9650&r2=9747

The problem is that there is no rule to generate the *.gif files (or any of the other files in apidoc/html/ except for index.html). In a built tree, "make dist" succeeds because the files will be generated by earlier build steps, but in the distcheck tree these earlier build steps aren't raised.

I think the cleanest fix is probably to revert revision 9747, and instead make a dist-hook rule or something similar to clean up the copied directory in the target.

The complete error log leading up to this can be seen in the buildbot: eg, at ​http://localhost:8010/xapian_head_clean_linux_amd64/builds/156/step-distcheck/0 if you have the usual ssh tunnel to buildbot running.

[Olly Betts]

I guess we'd need a "find" invocation to delete any files in that appropriate subtree of the "dist tree" which don't have the correct extension. A bit ugly, but then a multi-target rule isn't great either.

Hmm, actually, perhaps we can just provide the rule to copy over into the "dist tree".

Are you happy to look at this? I'm a bit short of time...

[Richard Boulton]

I'll try and take a look at this tomorrow.

[Richard Boulton]

Fixed in changeset [10462]. (distcheck is still broken, but it gets past the problem with the documentation files).

[Olly Betts]

The above isn't clear, but this change *has* been backported to 1.0.7.