#223 closed defect (released)
Add ability to do greater-than-or-equal searches on values
| Reported by: | Richard Boulton | Owned by: | New Bugs |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Matcher | Version: | SVN trunk |
| Severity: | normal | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Operating System: | All |
Description
OP_VALUE_RANGE can be used to perform a "less-than-or-equal" search, by setting the start of the range to "". However, it is not possible to perform a "greater-than-or-equal" search. It's very easy to implement support for this, but I'm not entirely certain of the best approach for this. However, after some thought and experimentation, I think that adding an OP_VALUE_GE query operator, and a constructor which takes this, a value slot number, and the value to use in the comparison, is the cleanest API. I've nearly put together a patch which implements this, which I'll attach here tomorrow.
What's our policy on adding new features to HEAD now? Should we be making a branch for 1.0.6 onwards first?
I can make another branch to hold little features like this, if it's not clear what state HEAD should be. But the fewer branches I have to maintain, the better.
This has now been implemented, and committed to HEAD, as OP_VALUE_GE. I've also added OP_VALUE_LE for symmetry (though this is internally implemented using a ValueRangePostList with an empty string for the start of the range, for now).