Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#208 closed defect (released)

Need to drop io.h patch from MSVC makefiles for 1.0.5 release

Reported by: Charlie Hull Owned by: Charlie Hull
Priority: normal Milestone:
Component: Other Version: SVN trunk
Severity: normal Keywords:
Cc: Olly Betts Blocked By:
Blocking: Operating System: Microsoft Windows

Description

This causes the build to fail on Windows as close() and _get_osfhandle() are undefined.

Attachments (2)

patch12.patch (306 bytes ) - added by Charlie Hull 17 years ago.
Adds io.h to fix Windows build problem
patch12.2.patch (306 bytes ) - added by Charlie Hull 17 years ago.
add io.h to fix Windows build problem

Download all attachments as: .zip

Change History (10)

by Charlie Hull, 17 years ago

Attachment: patch12.patch added

Adds io.h to fix Windows build problem

by Charlie Hull, 17 years ago

Attachment: patch12.2.patch added

add io.h to fix Windows build problem

comment:1 by Charlie Hull, 17 years ago

attachments.isobsolete: 01

comment:2 by Charlie Hull, 17 years ago

I've made a temporary patch in the 1.0.4 build files to fix this; if we could leave this bug open and assigned to me once HEAD is fixed, then that should remind me to sort it out for the 1.0.5 build files.

comment:3 by Olly Betts, 17 years ago

Owner: changed from New Bugs to Charlie Hull
Summary: Missing header file in remoteconnection.ccNeed to drop io.h patch from MSVC makefiles for 1.0.5 release

Fixed in SVN HEAD (r9558).

io.h isn't portable, so I used safeunistd.h which brings in io.h on windows.

comment:4 by Olly Betts, 17 years ago

Cc: olly@… added

comment:5 by Olly Betts, 17 years ago

Blocking: 200 added

Marking for 1.0.5

comment:6 by Charlie Hull, 17 years ago

Resolution: fixed
Status: newclosed

This mod never made it into SVN HEAD, so shouldn't appear in 1.0.5

comment:7 by Olly Betts, 17 years ago

Resolution: fixedreleased

comment:8 by Olly Betts, 17 years ago

Blocking: 200 removed
Operating System: Microsoft Windows
Note: See TracTickets for help on using tickets.