Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#116 closed defect (released)

python build tweaks

Reported by: Mark Hammond Owned by: Charlie Hull
Priority: normal Milestone:
Component: MSVC makefiles Version: SVN trunk
Severity: normal Keywords:
Cc: Richard Boulton, Charlie Hull Blocked By:
Blocking: Operating System: All

Description

Attaching a patch which includes a nice tip for avoiding modifications to config.mak, and a patch which avoids specifying the exact name of pythonxx.lib - python has a #pragma for MSVC which embeds the base name.

This should allow a Python bin distro to work with "nmake -f win32.mak PYTHON_DIR=..." - someone who builds from source will also need to override PYTHON_LIB_DIR. Charlie - please feel free to check this in with your defaults replacing any of mine which snuck in :)

Attachments (2)

pylib.2.patch (2.4 KB ) - added by Mark Hammond 17 years ago.
includes both relevant files
pylib.patch (1.5 KB ) - added by Mark Hammond 17 years ago.
patch as described

Download all attachments as: .zip

Change History (10)

comment:1 by Charlie Hull, 17 years ago

er, not sure how this works, don't you need to patch the Python make file as well to take account of PYTHON_LIB_DIR? Let me know and I'll incorporate it. I've made lots of other changes (hopefully for the better) as well, these will be in HEAD soon.

by Mark Hammond, 17 years ago

Attachment: pylib.patch added

patch as described

comment:2 by Mark Hammond, 17 years ago

attachments.isobsolete: 01

comment:3 by Richard Boulton, 17 years ago

I believe all these patches are now in HEAD - please comment if not, or close this bug if they are. ;-)

comment:4 by Richard Boulton, 17 years ago

Cc: richard@… added

comment:5 by Richard Boulton, 17 years ago

Cc: charlie@… added

comment:6 by Mark Hammond, 17 years ago

These patches are still showing as unapplied to me. It might be an artifact of the svn:eol-style change (thanks!), but I will not get to this for a few days.

comment:7 by Richard Boulton, 17 years ago

I've just applied some more updates from Charlie, so they may be applied now. Let us know.

comment:8 by Mark Hammond, 17 years ago

Resolution: fixed
Status: newclosed

Looks good - thanks!

comment:9 by Olly Betts, 17 years ago

Operating System: All
Resolution: fixedreleased

Fixed in 1.0.0 release.

Note: See TracTickets for help on using tickets.