Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#112 closed defect (released)

mingw build gives warning about 64 bit om_tostring method.

Reported by: Richard Boulton Owned by: Olly Betts
Priority: normal Milestone:
Component: Test Suite Version: SVN trunk
Severity: minor Keywords:
Cc: Blocked By:
Blocking: Operating System: Microsoft Windows

Description

The cygwin build reports:

common/utils.cc:82: warning: int format, different type arg (arg 3)

This warning looks bogus, but we should have a test to check that it works properly. This probably requires someone with a cygwin environment on windows to test it (currently, the tinderbox cygwin environment is a cross compile).

Attachments (1)

xapian-omtostring-test.patch (1.2 KB ) - added by Richard Boulton 18 years ago.
Patch to add required test to internaltest.cc

Download all attachments as: .zip

Change History (6)

by Richard Boulton, 18 years ago

Patch to add required test to internaltest.cc

comment:1 by Olly Betts, 18 years ago

Summary: Cygwin build gives warning about 64 bit om_tostring method.mingw build gives warning about 64 bit om_tostring method.

The tinderbox build is a linux -> mingw cross (on ixion). We no longer have any cygwin builds in the tindexbox.

Test looks fine, though checking conversions of a negative value, and an unsigned value with the top bit set would improve the coverage.

comment:2 by Richard Boulton, 18 years ago

I've committed the test - feel free to enhance, but it should give a basic coverage. We should probably leave this bug open for now in the hope that someone will report whether the test passes on mingw. (I'll try and look at it at some point, but we're focusing on MSVC builds for now.)

comment:3 by Olly Betts, 18 years ago

Status: newassigned

comment:4 by Olly Betts, 18 years ago

Resolution: fixed
Status: assignedclosed

I've fixed this warning (I put the string into a static const array initialised character by character!)

And I've run the cross-built mingw test executables on XP too and all passed, so closing this bug now.

comment:5 by Olly Betts, 18 years ago

Operating System: Microsoft Windows
Resolution: fixedreleased

Fixed in 1.0.0 release.

Note: See TracTickets for help on using tickets.