#112 closed defect (released)
mingw build gives warning about 64 bit om_tostring method.
Reported by: | Richard Boulton | Owned by: | Olly Betts |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Test Suite | Version: | SVN trunk |
Severity: | minor | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Operating System: | Microsoft Windows |
Description
The cygwin build reports:
common/utils.cc:82: warning: int format, different type arg (arg 3)
This warning looks bogus, but we should have a test to check that it works properly. This probably requires someone with a cygwin environment on windows to test it (currently, the tinderbox cygwin environment is a cross compile).
Attachments (1)
Change History (6)
by , 18 years ago
Attachment: | xapian-omtostring-test.patch added |
---|
comment:1 by , 18 years ago
Summary: | Cygwin build gives warning about 64 bit om_tostring method. → mingw build gives warning about 64 bit om_tostring method. |
---|
The tinderbox build is a linux -> mingw cross (on ixion). We no longer have any cygwin builds in the tindexbox.
Test looks fine, though checking conversions of a negative value, and an unsigned value with the top bit set would improve the coverage.
comment:2 by , 18 years ago
I've committed the test - feel free to enhance, but it should give a basic coverage. We should probably leave this bug open for now in the hope that someone will report whether the test passes on mingw. (I'll try and look at it at some point, but we're focusing on MSVC builds for now.)
comment:3 by , 18 years ago
Status: | new → assigned |
---|
comment:4 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I've fixed this warning (I put the string into a static const array initialised character by character!)
And I've run the cross-built mingw test executables on XP too and all passed, so closing this bug now.
comment:5 by , 18 years ago
Operating System: | → Microsoft Windows |
---|---|
Resolution: | fixed → released |
Fixed in 1.0.0 release.
Patch to add required test to internaltest.cc