Opened 18 years ago
Last modified 21 months ago
#178 assigned defect
No remote backend support for: spelling correction, synonyms, matchdecider — at Version 14
| Reported by: | Richard Boulton | Owned by: | Richard Boulton |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.0.0 |
| Component: | Backend-Remote | Version: | git master |
| Severity: | normal | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Operating System: | All |
Description (last modified by )
The remote database was briefly feature complete, but it's fallen behind again - it doesn't support spelling correction, synonym expansion, or matchdeciders.
We should add these in to it at some point.
Change History (14)
comment:1 by , 18 years ago
| Blocking: | 120 added |
|---|
comment:2 by , 18 years ago
| Owner: | changed from to |
|---|
comment:3 by , 18 years ago
| Status: | new → assigned |
|---|
comment:4 by , 18 years ago
| Cc: | added |
|---|---|
| Summary: | Remote database does not support spelling correction → Remote database does not support spelling correction or synonyms |
It never supported matchdeciders. I don't believe those or matchspies are implementable in 1.0.x.
Let's make this bug for spelling correction and synonyms, and bug#183 can be for remote support for Xapian::MatchDecider.
comment:5 by , 18 years ago
| Operating System: | → All |
|---|---|
| Summary: | Remote database does not support spelling correction or synonyms → No remote backend support for: spelling correction, synonyms, metadata |
And now ... metadata!
comment:7 by , 17 years ago
| Description: | modified (diff) |
|---|---|
| Milestone: | → 1.1 |
comment:8 by , 17 years ago
| Blocking: | 120 removed |
|---|
(In #120) Remove the unfixed dependencies so we can close this bug - they're all marked for the 1.1.0 milestone.
comment:9 by , 16 years ago
| Milestone: | 1.1.0 → 1.1.1 |
|---|
These aren't incompatible changes (except for remote protocol changes) so bumping to 1.1.1.
comment:11 by , 16 years ago
| Milestone: | 1.1.7 → 1.2.0 |
|---|
These can be implemented in 1.2.x without incompatible changes. Bumping.
by , 15 years ago
| Attachment: | metadata_and_mvcms_register.patch added |
|---|
comment:12 by , 15 years ago
I've added a patch against the matchspy branch that does metadata and also registers MultiValueCountMatchSpy.
comment:13 by , 15 years ago
Incidentally - another thing that remote databases don't support: Enquire.get_mset can take a matchdecider, but that has no effect for remote databases.
comment:14 by , 15 years ago
| Description: | modified (diff) |
|---|---|
| Summary: | No remote backend support for: spelling correction, synonyms, metadata → No remote backend support for: spelling correction, synonyms, matchdecider |
The MultiValueCountMatchSpy patch hunk isn't relevant for trunk, as that class doesn't exist there.
This changes the remote protocol incompatibly, so XAPIAN_REMOTE_PROTOCOL_MAJOR_VERSION needs bumping from 33 to 34, which I've done.
Also, the documentation for the remote protocol (remote_protocol.html) needs updating, which I've also done.
RemoteServer::set_metadata() was truncating at zero bytes in the value - I've extended the metadata1 test to cover cases with zero bytes, and fixed the patch.
And the new methods use 2 space indents rather than the standard 4, so I fixed that too.
I assume this work is (C) Lemur, so I updated the headers to reflect that. If that's wrong, let me know.
Committed to trunk with the changes above as r13688.
We should probably try and get this done in the 1.0.x series.