#87 closed defect (released)
query.cc:set_probabilistic returns NEW_QUERY when the query hasn't changed
Reported by: | Mike Trinkala | Owned by: | Olly Betts |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Omega | Version: | 0.9.6 |
Severity: | normal | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Operating System: | All |
Description
query.cc:set_probabilistic returns NEW_QUERY when the query hasn't changed. This occurs when a prefix term contains a period such as mime:application/vnd.ms-excel
Using $setmap{boolprefix,mime,T} the previous query value becomes: xP=Tapplication/vnd.ms-excel.
The previous query string is parsed on '.' producing two terms. The short-cut code returns NEW_QUERY preventing the user from being able to browse more then the first page of results
short-cut: if the new query has fewer terms, it must be a new one
Attachments (1)
Change History (7)
comment:1 by , 18 years ago
Status: | new → assigned |
---|
comment:2 by , 18 years ago
The xP query string is still constructed with periods, the behavior is unchanged.
comment:3 by , 18 years ago
Oh sorry - you also need to change the query template where xP is produced to:
$if{$queryterms,<INPUT TYPE=hidden NAME=xP VALUE="$html{$queryterms}">}
comment:4 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
That works much better :) New and old save queries appear to be working fine.
comment:6 by , 18 years ago
Operating System: | → All |
---|---|
Resolution: | verified → released |
Even without the short-cut, the term will get split at the dot and not match. We need to use a different separator I guess. I've produced a patch which compiles but I've not tested otherwise as I have a large backlog from being away. If you could try it out, that'd be great.