Opened 12 years ago

Closed 12 years ago

#576 closed defect (fixed)

xapian.php from 1.2.7 causes php notices

Reported by: Dougle Owned by:
Priority: normal Milestone: 1.2.8
Component: Xapian-bindings (PHP) Version: 1.2.7
Severity: minor Keywords:
Cc: Blocked By:
Blocking: Operating System: All

Description (last modified by Olly Betts)

[11-Nov-2011 12:49:51] PHP Notice:  Undefined variable: r in xapian.php on line 3129
[11-Nov-2011 12:49:51] PHP Notice:  Undefined variable: r in xapian.php on line 3137

Change History (1)

comment:1 by Olly Betts, 12 years ago

Description: modified (diff)
Milestone: 1.2.8
Resolution: fixed
Status: newclosed

I fixed this issue in SWIG a while back and updated trunk to using the latest SWIG to generate the bindings (and a regression test was added in r15934). 1.2 branch also got a newer SWIG with this fix, but after 1.2.7 was released (I can't seem to get it to tell me just when svn:externals was updated, but these bogus return $r; statements are gone on the tip of the 1.2 branch.

So this is already fixed ready for 1.2.8, and I've just backported the regression test too (r16123) to ensure this stays fixed.

Note: See TracTickets for help on using tickets.