Opened 14 years ago

Closed 7 years ago

Last modified 7 years ago

#478 closed defect (fixed)

Ruby bindings failing ValueCountMatchSpy test

Reported by: Charlie Hull Owned by: Charlie Hull
Priority: normal Milestone: 1.2.20
Component: MSVC makefiles Version: 1.2.0
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Operating System: Microsoft Windows

Description

I'm getting a test failure as follows, both in SVN trunk and in 1.2.0:

Loaded suite smoketest
Started
...............E..
Finished in 0.015 seconds.

  1) Error:
test_015_valuecount_matchspy(XapianSmoketest):
NameError: uninitialized constant Xapian::ValueCountMatchSpy
    smoketest.rb:213:in `test_015_valuecount_matchspy'

18 tests, 39 assertions, 0 failures, 1 errors
NMAKE : fatal error U1077: 'c:\Ruby\bin\ruby.exe' : return code '0x1'
Stop.

Change History (7)

comment:1 by Olly Betts, 14 years ago

Component: Xapian-bindingsMSVC makefiles
Owner: changed from Olly Betts to Charlie Hull

This works with the Xapian build system, so I don't have any good ideas.

comment:2 by Olly Betts, 13 years ago

Are you still seeing this? I wondered if it might be due to stale generated sources, like that more recent issue.

comment:3 by Charlie Hull, 13 years ago

Yes, still seeing it with generated sources from a recent snapshot.

comment:4 by Olly Betts, 13 years ago

What Ruby version is this with (assuming you still see it with the latest 1.2.x release)?

comment:5 by Olly Betts, 10 years ago

Looking at this again, I notice you aren't passing -I. in the DOTEST target in win32_bindings_ruby.mak, which is needed so that ruby will look for xapian.rb and _xapian.so in the current directory.

This:

        "$(RUBY_EXE)" smoketest.rb

should be:

        "$(RUBY_EXE)" -I. smoketest.rb

That issue alone should result in an error at require 'xapian', but my suspicion is that you have an older version of the ruby bindings installed somewhere such that ruby is using that instead, and this older version lacks the code which wraps Xapian::ValueCountMatchSpy, hence the test fails.

comment:6 by Olly Betts, 7 years ago

Milestone: 1.3.3
Resolution: fixed
Status: newclosed

I applied the fix from comment:5 more than 2 years ago in 4d92b56bdc0061211f39bb54e44d58803badff96 (somewhere between 1.3.2 and 1.3.3). It seems like the obvious fix to me, so in the absence of any feedback for more than 3 years I'm going to close this.

comment:7 by Olly Betts, 7 years ago

Milestone: 1.3.31.2.20

Oh and this was backported to the 1.2 branch in 8644ba3cbb8b18e876774523a4383df84afd4eac before 1.2.20.

Note: See TracTickets for help on using tickets.