Opened 14 years ago

Closed 14 years ago

#462 closed defect (fixed)

Memory leaks from database exceptions in QueryParser

Reported by: Olly Betts Owned by: Olly Betts
Priority: normal Milestone: 1.0.19
Component: QueryParser Version: 1.1.4
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Operating System: All

Description

QueryParser calls methods on Database in some situations, and if this results in an exception (DatabaseModifiedError is the most likely case), this can result in memory leaks.

Mailing list discussion (with testcase):

​http://article.gmane.org/gmane.comp.search.xapian.general/8223

Attachments (1)

test.cpp​ (1.5 KB ) - added by Olly Betts 14 years ago.
Testcase from mailing list

Download all attachments as: .zip

Change History (4)

by Olly Betts, 14 years ago

Attachment: test.cpp​ added

Testcase from mailing list

comment:1 by Olly Betts, 14 years ago

Committed r14274 which fixes the leak of the parser structure and r14277 which tidies this up a bit.

Leaking of tokens from the parsing is probably going to be trickier, so we may have to leave that for a later release.

comment:2 by Olly Betts, 14 years ago

Milestone: 1.1.5 → 1.0.19
Status: new → assigned

Fixed for trunk in r14282. Needs backporting (for flint) for 1.0.19.

comment:3 by Olly Betts, 14 years ago

Resolution: → fixed
Status: assigned → closed

Backported to 1.0 - the first fix as r14284 and the second as r14285.

Note: See TracTickets for help on using tickets.