Ticket #420 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

Patch for a few Perl issues

Reported by: Henry Owned by: olly
Priority: normal Milestone: 1.0.18
Component: Search::Xapian Version: SVN trunk
Severity: normal Keywords:
Cc: Blocked By:
Operating System: All Blocking:

Description

Please find attached a patch (against current svn) for consideration. It covers a few missing elements on the Perl side of things:

add_spelling() and test/s. remove_spelling() and test/s. get_corrected_query_string() and test/s. get_spelling_suggestion() and test/s.

man pages for the above and for WritableDatabase::close() are also patched.

Please let me know of any errors (especially in the test suites). I've successfully patched, compiled, and subsequently indexed using the changes.

Attachments

xapian-perl.patch Download (7.4 KB) - added by Henry 9 months ago.

Change History

Changed 9 months ago by Henry

Changed 9 months ago by olly

  • status changed from new to assigned
  • component changed from Xapian-bindings to Search::Xapian
  • milestone set to 1.0.18

The documentation for WritableDatabase::close should really be for Database::close, but this method doesn't seem to be wrapped for Perl anyway currently, so I've not applied that bit...

The rest I've committed as r13787.

Marking for backporting.

Changed 9 months ago by olly

  • status changed from assigned to closed
  • resolution set to fixed

Backported for 1.0.18 as r13789.

Changed 9 months ago by Henry

My surname for the Changes file: Combrinck 'Henry' on it's own seems so mysterious.

Changed 9 months ago by olly

OK, filled in - I couldn't remember what it was, or trivially find it.

Note: See TracTickets for help on using tickets.