Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#368 closed defect (fixed)

Xapian 1.1.0 does not compile on CentOS 4.7

Reported by: Miki Tebeka Owned by: Olly Betts
Priority: normal Milestone: 1.1.3
Component: Other Version: 1.1.0
Severity: normal Keywords:
Cc: Blocked By:
Blocking: Operating System: All

Description

Due to older version of the uuid library that doesn't have uuid_unparse_lower.

This patch to common/safeuuid.h fixed the problem:

#ifndef UUID_TYPE_DCE_TIME // Old UUID
#include <ctype.h>
static inline void
uuid_unparse_lower(const uuid_t uu, char *out)
{
    char *cp;

    uuid_unparse(uu, out);
    for (cp = out; *cp; ++cp) {
        *cp = tolower(*cp);
    }
}

#endif

Change History (5)

comment:1 by Olly Betts, 15 years ago

Milestone: 1.1.1
Status: newassigned

Thanks. Marking to fix for 1.1.1.

Relying on UUID_TYPE_DCE_TIME seems brittle - even if this really got added in the exact same release as uuid_unparse_tolower(), there may well be versions out there with backported patches for one or the other. We should use a configure test instead.

comment:2 by Olly Betts, 15 years ago

Resolution: fixed
Status: assignedclosed

Fixed in trunk r12704.

comment:3 by Olly Betts, 15 years ago

Oops, and r12705 as I got the buffer length wrong.

comment:4 by Olly Betts, 15 years ago

Component: OtherBackend-Muscat 3.6
Milestone: 1.1.11.1.3

The fix had a compile error in it, as just reported by Liu Haifeng.

I've fixed this problem in r13438, after checking that it compiled when forced to be used.

comment:5 by Olly Betts, 15 years ago

Component: Backend-Muscat 3.6Other

Um, and undoing my accidental change to "component"...

Note: See TracTickets for help on using tickets.