Ticket #296 (assigned enhancement)

Opened 4 months ago

Last modified 3 weeks ago

Add spelling suggestion to Omega

Reported by: pion Owned by: olly
Priority: normal Milestone: 1.1.1
Component: Omega Version: 1.0.8
Severity: normal Keywords:
Cc: Blocked By:
Operating System: All Blocking:

Description

This is a small patch to Omega and scriptindex to enable support for spelling suggestion. To use it, in your scriptindex database definition file add the SPELL keyword to any field whose contents you want added to the spelling dictionary, reindex the database, and add the $suggestion keyword to your Omegascript output template.

A variation of this patch might instead add words to the spelling dictionary by default, and then provide a NOSPELL scriptindex keyword to prevent addition. A command-line option to scriptindex could also globally enable/disable spelling support.

Attachments

query.cc.diff (1.1 kB) - added by pion 4 months ago.
scriptindex.cc.spelling.diff (2.8 kB) - added by pion 4 months ago.

Change History

  Changed 4 months ago by olly

  • keywords spell, spelling, suggestion, correction, omega, scriptindex removed
  • status changed from new to assigned

Thanks.

follow-up: ↓ 3   Changed 4 months ago by olly

Hmm, the attachments are getting the wrong content type, and I can't see how to edit that - I think the ".108" is confusing things.

Can you reattach them, but with extension ".patch"?

Changed 4 months ago by pion

in reply to: ↑ 2   Changed 4 months ago by pion

Replying to olly:

Hmm, the attachments are getting the wrong content type, and I can't see how to edit that - I think the ".108" is confusing things. Can you reattach them, but with extension ".patch"?

Oops, I did .diff instead. Seems to work ok in Trac, though. Or do you need .patch?

Changed 4 months ago by pion

  Changed 3 months ago by olly

".diff" is fine too.

I think an explicit "spell" is probably best in scriptindex.

The patches look OK, apart from the lack of corresponding documentation updates. If you could update the documentation too that would be most appreciated.

  Changed 3 weeks ago by olly

  • milestone changed from 1.1.0 to 1.1.1

Bumping milestone to 1.1.1 as this is ready to apply (no documentation) and isn't an incompatible change.

Note: See TracTickets for help on using tickets.