Xapian 10521 doesn't build on windows using msvc

[brunovianarezende]

When trying to compile the xapian version got from xappy's site I get an error complaining about expand.cc. If I apply the attached patch, compilation finishs but I get in the end of the tests:

.\apitest.EXE completed test run: All 27 tests passed, 6 skipped. .\apitest.EXE total: 896 tests passed, 6 failed, 37 skipped. NMAKE : fatal error U1077: '.\apitest.EXE' : return code '0x1' Stop. NMAKE : fatal error U1077: '"C:\Arquivos de programas\Microsoft Visual Studio 8\VC\BIN\nmake.EXE"' : return code '0x2' Stop.

[richard]

Thank you for the report. The xapian versions on xappy's site are specific to xappy (they're built by merging the changes on several branches with trunk), so it's probably best to report bugs about them there in future.

I will attempt to apply your patch in the appropriate places, anyway. Actually, in this case I believe the patch is needed on the trunk of xapian, too, so I've applied it there - I will get Charlie to check that the trunk now compiles on windows, and will then regenerate the xappy xapian packages.

The 6 failed tests are an expected error with the version on xappy's site (they're due to a test of the OP_SYNONYM feature being overly demanding), so the library you have built is probably fine now.

[richard]

We've definitely successfully compiled xapian versions more recent than 10521, and also the xapian packages in xappy built from more recent xapian's than that, so I'm marking this as fixed.