Ticket #244 (closed defect: fixed)

Opened 9 months ago

Last modified 7 months ago

bindings should use "swig -MD"

Reported by: olly Owned by: richard
Priority: high Milestone: 1.1.0
Component: Xapian-bindings Version: SVN trunk
Severity: normal Keywords:
Cc: Blocked By:
Operating System: All Blocking:

Description (last modified by olly) (diff)

SWIG supports automatic generation of dependencies via -MD, etc options similar to those which GCC supports. The bindings should use this to ease development - then if you modify a xapian-core header which SWIG parses directly, make in the bindings will know to rerun SWIG.

Attachments

xapian-config-kill-swig-headers.patch (2.1 kB) - added by olly 7 months ago.
Combined patch to remove --swig-headers

Change History

Changed 9 months ago by olly

  • blocking set to 160

We've not yet made a release with --swigheaders in so we should address this for 1.1 so we don't need to worry about compatibility between releases with/without support for --swigheaders.

Changed 8 months ago by olly

  • status changed from new to assigned

Changed 8 months ago by trac

  • platform set to All

Changed 7 months ago by richard

  • description modified (diff)
  • milestone set to 1.1

Changed 7 months ago by richard

  • blocking deleted

Changed 7 months ago by olly

  • owner changed from newbugs to richard
  • status changed from assigned to new

Changed 7 months ago by olly

Combined patch to remove --swig-headers

Changed 7 months ago by olly

  • description modified (diff)
  • milestone deleted

In fact, I'm just going to back out the --swigheaders change, and unset the milestone on this bug. Once we release a xapian-config with this option, we have to worry about breaking compatibility if we remove it again, so we definitely need to resolve that part for 1.1.0.

The second part - using -MD instead - is less urgent I think. Nobody has complained about the lack of such dependencies in release versions - these dependencies are really only useful if you're developing and so might modify xapian-core. And there's an easy workaround - just: touch xapian.i

Changed 7 months ago by richard

  • priority changed from normal to high
  • status changed from new to assigned

This is currently breaking buildbot (or, at least, the buildbot builders which just do svn update then make, which is the majority of them). I could fix it manually for each builder (by doing "touch xapian.i"), but that's tedious and it would just break with the next change to the bindings anyway.

I agree that this doesn't need to block a release, but we do need to have a working buildbot to help ensure that code which is released compiled in different environments, so I'm increasing the priority of this bug so I don't forget to address it soon.

Changed 7 months ago by richard

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone set to 1.1.0

Completed on SVN HEAD. Bindings now use -MD to get dependencies.

Note: See TracTickets for help on using tickets.