Opened 17 years ago

Closed 15 years ago

#139 closed enhancement (fixed)

non-const method cleanup

Reported by: Olly Betts Owned by: Olly Betts
Priority: lowest Milestone: 1.1.2
Component: Other Version: SVN trunk
Severity: minor Keywords:
Cc: Blocked By:
Blocking: Operating System: All

Description

Check internal classes for methods which aren't declared const but could be.

Change History (8)

comment:1 by Olly Betts, 17 years ago

Blocking: 120 added
Operating System: All
Owner: changed from Olly Betts to Not currently assigned

comment:3 by Richard Boulton, 16 years ago

Milestone: 1.1

comment:4 by Richard Boulton, 16 years ago

Blocking: 120 removed

(In #120) Remove the unfixed dependencies so we can close this bug - they're all marked for the 1.1.0 milestone.

comment:5 by Olly Betts, 15 years ago

Milestone: 1.1.01.1.1

No patch, no incompatible changes required.

comment:6 by Olly Betts, 15 years ago

Milestone: 1.1.11.1.7

comment:7 by Olly Betts, 15 years ago

Milestone: 1.1.71.1.4

comment:8 by Olly Betts, 15 years ago

Milestone: 1.1.41.1.2
Owner: changed from Not currently assigned to Olly Betts
Status: newassigned

This is an easy one to knock off gradually in odd moments while waiting for things to run, so I've been working on it.

So far I've done an audit and added const where it was missing in xapian-core, except for a few possibilities in the test harness.

comment:9 by Olly Betts, 15 years ago

Resolution: fixed
Status: assignedclosed

Omega done too.

I don't think the test harness ones are useful to fix - they seem to be cases which could be const as implemented now, but not for other plausible approaches, so the const isn't especially natural. So I'm closing this now.

Note: See TracTickets for help on using tickets.