Ticket #208 (closed defect: released)

Opened 15 months ago

Last modified 13 months ago

Need to drop io.h patch from MSVC makefiles for 1.0.5 release

Reported by: charlie Owned by: charlie
Priority: normal Milestone:
Component: Other Version: SVN trunk
Severity: normal Keywords:
Cc: olly Blocked By:
Operating System: Microsoft Windows Blocking:

Description

This causes the build to fail on Windows as close() and _get_osfhandle() are undefined.

Attachments

patch12.patch (306 bytes) - added by charlie 15 months ago.
Adds io.h to fix Windows build problem
patch12.2.patch (306 bytes) - added by charlie 15 months ago.
add io.h to fix Windows build problem

Change History

Changed 15 months ago by charlie

Adds io.h to fix Windows build problem

Changed 15 months ago by charlie

add io.h to fix Windows build problem

Changed 15 months ago by charlie

  • attachments.isobsolete changed from 0 to 1

Changed 15 months ago by charlie

I've made a temporary patch in the 1.0.4 build files to fix this; if we could leave this bug open and assigned to me once HEAD is fixed, then that should remind me to sort it out for the 1.0.5 build files.

Changed 15 months ago by olly

  • owner changed from newbugs to charlie
  • summary changed from Missing header file in remoteconnection.cc to Need to drop io.h patch from MSVC makefiles for 1.0.5 release

Fixed in SVN HEAD (r9558).

io.h isn't portable, so I used safeunistd.h which brings in io.h on windows.

Changed 15 months ago by olly

  • cc olly@… added

Changed 15 months ago by olly

  • blocking set to 200

Marking for 1.0.5

Changed 14 months ago by charlie

  • status changed from new to closed
  • resolution set to fixed

This mod never made it into SVN HEAD, so shouldn't appear in 1.0.5

Changed 13 months ago by olly

  • resolution changed from fixed to released

Changed 13 months ago by olly

  • blocking deleted

Changed 13 months ago by trac

  • platform set to Microsoft Windows
Note: See TracTickets for help on using tickets.