Ticket #184 (closed defect: released)

Opened 3 years ago

Last modified 3 years ago

msvc builds failing to generate version.h

Reported by: mhammond Owned by: charliejuggler
Priority: normal Milestone:
Component: MSVC makefiles Version: SVN trunk
Severity: normal Keywords:
Cc: olly, richard Blocked By:
Operating System: Microsoft Windows Blocking: #154

Description

The msvc builds appear to be failing due to a missing version.h[1]. I'm attaching a patch that works for me.

[1]  http://buildbot.enfoldsystems.com/xapian/xapian-msvc/builds/323/step-compile/0

Attachments

gen_version_h.patch Download (1.2 KB) - added by mhammond 3 years ago.
generate include\xapian\version.h from msvc\version.h.in
patch10.patch Download (1.0 KB) - added by charliejuggler 3 years ago.
Fix makefile

Change History

Changed 3 years ago by mhammond

generate include\xapian\version.h from msvc\version.h.in

Changed 3 years ago by richard

  • status changed from new to closed
  • resolution set to fixed

Applied

Changed 3 years ago by olly

  • cc olly@… added
  • status changed from closed to reopened
  • resolution fixed deleted

I believe this change will break builds from tarballs, since genversion.pl isn't shipped. If we're taking this approach, it probably should ship with the MSVC makefiles archive.

Also, comments in genversion.pl need updating to reflect this revised approach.

And there's no point configure generating msvc/version.h now either, nor in us shipping it. I'll fix the last part - the rest is better done by someone who can test on MS Windows.

Changed 3 years ago by olly

  • blocking 154 added

While we could fix this by updating the msvc makefiles after the 1.0.3 release, we're stuffed if we discover that changes to xapian-core are needed. So marking this as a blocker.

Changed 3 years ago by richard

Agreed that builds from tarballs are broken currently.

Agreed that there's no point in configure generating msvc/version.h (or shipping it) - we should have a consistent way of generating the version.h file, whether its a tarball or an svn build.

msvc/version.h.in and msvc/genversion.pl should be distributed together, since they're useless separately. There's no particular reason that they should be separate from the rest of the build files - perhaps they should both be moved into xapian-maintainer-tools/win32msvc/ with the other files.

Changed 3 years ago by richard

Changes made - genversion.pl and msvc/version.h are now in win32msvc/, and I've removed the generation of version.h from the tarball.

Changed 3 years ago by olly

Thanks - so does this just need testing with a tarball now?

Changed 3 years ago by olly

  • cc richard@… added
  • op_sys changed from All to Windows NT

Setting OS correctly; adding Richard to the Cc list (since I assume he wants to be!)

Changed 3 years ago by richard

Yes, it just needs testing. I'll try and get round to it shortly if Charlie doesn't.

Changed 3 years ago by charliejuggler

Fix makefile

Changed 3 years ago by olly

  • status changed from reopened to closed
  • resolution set to fixed

Patch applied.

I assume that with this patch, everything now works? I'll close the bug, but please reopen if I've mis-inferred.

Changed 3 years ago by charliejuggler

Yep, it builds and tests.

Changed 3 years ago by olly

  • resolution changed from fixed to released

Fixed in 1.0.4

Changed 3 years ago by trac

  • platform set to Microsoft Windows
Note: See TracTickets for help on using tickets.