Ticket #112 (closed defect: released)

Opened 23 months ago

Last modified 20 months ago

mingw build gives warning about 64 bit om_tostring method.

Reported by: richard Owned by: olly
Priority: normal Milestone:
Component: Test Suite Version: SVN trunk
Severity: minor Keywords:
Cc: Blocked By:
Operating System: Microsoft Windows Blocking:

Description

The cygwin build reports:

common/utils.cc:82: warning: int format, different type arg (arg 3)

This warning looks bogus, but we should have a test to check that it works properly. This probably requires someone with a cygwin environment on windows to test it (currently, the tinderbox cygwin environment is a cross compile).

Attachments

xapian-omtostring-test.patch (1.2 kB) - added by richard 23 months ago.
Patch to add required test to internaltest.cc

Change History

Changed 23 months ago by richard

Patch to add required test to internaltest.cc

Changed 23 months ago by olly

  • summary changed from Cygwin build gives warning about 64 bit om_tostring method. to mingw build gives warning about 64 bit om_tostring method.

The tinderbox build is a linux -> mingw cross (on ixion). We no longer have any cygwin builds in the tindexbox.

Test looks fine, though checking conversions of a negative value, and an unsigned value with the top bit set would improve the coverage.

Changed 23 months ago by richard

I've committed the test - feel free to enhance, but it should give a basic coverage. We should probably leave this bug open for now in the hope that someone will report whether the test passes on mingw. (I'll try and look at it at some point, but we're focusing on MSVC builds for now.)

Changed 22 months ago by olly

  • status changed from new to assigned

Changed 22 months ago by olly

  • status changed from assigned to closed
  • resolution set to fixed

I've fixed this warning (I put the string into a static const array initialised character by character!)

And I've run the cross-built mingw test executables on XP too and all passed, so closing this bug now.

Changed 20 months ago by olly

  • resolution changed from fixed to released

Fixed in 1.0.0 release.

Changed 20 months ago by trac

  • platform set to Microsoft Windows
Note: See TracTickets for help on using tickets.